From: Simon 'corecode' Schubert <corecode@fs.ei.tum.de>
Date: Fri, 16 Feb 2007 19:43:30 GMT
Subject: Re: [PATCH] pager: use an environment variable for pager_in_use
Message-ID: <45D60962.6010605@fs.ei.tum.de>
In-Reply-To: <Pine.LNX.4.63.0702162004590.22628@wbgn013.biozentrum.uni-wuerzburg.de>

Johannes Schindelin wrote:
>> Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
>>> +int pager_in_use = getenv("GIT_PAGER_IN_USE");
>> test.c:3: error: initializer element is not constant
> Sorry.
> 
> Still, it feels wrong to use two system calls when you need none.

getenv() is usually no system call, but processed in userland.

However, I also always get the feeling that using environment variables within one process to communicate state seems wrong, but many old unix tools do it this way.

cheers
  simon

-- 
Serve - BSD     +++  RENT this banner advert  +++    ASCII Ribbon   /"\
Work - Mac      +++  space for low €€€ NOW!1  +++      Campaign     \ /
Party Enjoy Relax   |   http://dragonflybsd.org      Against  HTML   \
Dude 2c 2 the max   !   http://golden-apple.biz       Mail + News   / \