From: Andreas Ericsson <ae@op5.se>
Date: Fri, 19 Jan 2007 01:24:36 GMT
Subject: Re: git-send-email --suppress-from option doesn't work.
Message-ID: <45B01DD4.7000204@op5.se>
In-Reply-To: <45AFE18C.2020303@freescale.com>



Timur Tabi wrote:
> The --suppress-from option doesn't work for me because the comparison is
> too strict.
> 
> Here's an example usage of git-send-email:
> 
> git-send-email --suppress-from --from timur@freescale.com --to
> timur@tabi.org --smtp-server remotesmtp.freescale.net
> 0001-Add-support-for-the-MPC8349E-mITX-GP.txt
> 
> I need to specify the --from option, because otherwise git-send-email
> will prompt me for a From address, and I don't want it to prompt me for
> anything.
> 
> The problem is that the patchfile contains this line:
> 
> From: Timur Tabi <timur@freescale.com>
> 
> That means that the patchfile contains the string "Timur Tabi
> <timur@freescale.com>", but the --from specifies the string
> "timur@freescale.com".  The code which checks the suppress-from option
> is here:
> 
>                         } elsif (/^(Cc|From):\s+(.*)$/) {

I believe

	(/^(Cc|From):[^<]+<([^>])+>.*$/)

would do the trick for your case. It would however fail when specifying a proper
--from address in the 'git commit --author="Foo Barson <foo@barson.com>"' style.

Are you sure you need to specify --from for those patches though?

>                                 if ($2 eq $from) {
>                                         next if ($suppress_from);
>                                 }
> 
> I don't know Perl, but I'm guess the The "$2 eq $from" is a strict
> comparison that fails in my case.
> 
> Some of you might say at this point, "Why don't you  just specify --from
> "Timur Tabi <timur@freescale.com>"?  I tried that, and it still doesn't
> work.
> 

That sounds extremely odd indeed. Could this have to do with character
conversion?

-- 
Andreas Ericsson                   andreas.ericsson@op5.se
OP5 AB                             www.op5.se
Tel: +46 8-230225                  Fax: +46 8-230231