From: René Scharfe <l.s.r@web.de>
Date: Sat, 08 Feb 2020 10:55:00 GMT
Subject: Re: [PATCH v3 04/13] run-command: make `exists_in_PATH()` non-static
Message-ID: <4550b9a5-74ef-2739-990b-6f41f3319129@web.de>
In-Reply-To: <20200208090704.26506-5-mirucam@gmail.com>

Am 08.02.20 um 10:06 schrieb Miriam Rubio:
> From: Pranit Bauva <pranit.bauva@gmail.com>
>
> Removes the `static` keyword from `exists_in_PATH()` function
> and declares the function in `run-command.h` file.
> The function will be used in bisect_visualize() in a later
> commit.

I couldn't find the mentioned later commit in this series.  Do you
actually still need to export exists_in_PATH()?

And if yes: locate_in_PATH() splits PATH by colon.  That means it
doesn't work on Windows, where the paths are separated by semicolons.
exists_in_PATH() wraps it, so it shares that limitation.  Wouldn't that
cause issues for your use?

René