From: Han-Wen Nienhuys <hanwen@xs4all.nl>
Date: Thu, 02 Nov 2006 10:53:30 GMT
Subject: Re: Suggestion: drop 'g' in git-describe suffix
Message-ID: <4549CE2A.3010808@xs4all.nl>
In-Reply-To: <4549CA6B.4090909@shadowen.org>

Andy Whitcroft escreveu:
> Han-Wen Nienhuys wrote:
>> Andy Whitcroft escreveu:
>>>> or some other non-hex character.
>>> g is not a hex digit, hex is 0-f ??
>>>
>> Yes of course; silly me. Still I think it would be clearer if it used a
>> non-alphabet char, eg.
>>
>>   tag+sha1
>>
>> to separate the tag and the committish.
> 
> Well there is a non-alphabet character in there, a minus (-).  The g
> prefix on the sha1 _fragment_ it to indicate that it is in fact a
> truncated sha1, not a complete one.  

is this policy documented somewhere?  None of the tools understand it.

[lilydev@haring git]$ git describe
v1.4.3.3-g1e1f76e
[lilydev@haring git]$ git show g1e1f76e
fatal: ambiguous argument 'g1e1f76e': unknown revision or path not in 
the working tree.
Use '--' to separate paths from revisions

My suggestion is to use

   v1.4.3.3+1e1f76e

here.

> If you want the complete clean sha1
> this is not the way to get it?


-- 
  Han-Wen Nienhuys - hanwen@xs4all.nl - http://www.xs4all.nl/~hanwen