From: A Large Angry SCM <gitzilla@gmail.com>
Date: Thu, 12 Oct 2006 22:20:09 GMT
Subject: Re: [PATCH 1/2] diff --stat: use asymptotic scaling in graph
Message-ID: <452EBF99.5020108@gmail.com>
In-Reply-To: <d620685f0610121437m38eb454g7597b2a93010b023@mail.gmail.com>

apodtele wrote:
> On 10/12/06, Martin Waitz <tali@admingilde.org> wrote:
>> On Thu, Oct 12, 2006 at 03:37:17PM -0400, apodtele wrote:
>> > Instead of conditionally scaling the stat graph for large changes,
>> > always scale it asymptotically: small changes shall appear without any
>> > distortions.
>>
>> very nice idea!
>>
>> > +     return it * width / (it + width) + 1;
>>
>> but wouldn't this formula result in at least 1, even for a 0 change?
>> Perhaps we'd have to special case an input of 0?
[...]
> +    if (it)
> +        return it * width / (it + width) + 1;
> +    else
> +        return 0;

No conditional needed:

	return it * width / (it + width - 1)