From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Tue, 06 Oct 2026 09:16:25 GMT
Subject: Re: [PATCH] t5551: fix quoting in curl version bug prereq
Message-ID: <4526e397-734e-d378-bb1d-31dd969c90ea@gmx.de>
In-Reply-To: <20261006034331.GA1325722@coredump.intra.peff.net>

Hi Jeff,

On Mon, 5 Oct 2026, Jeff King wrote:

> On Thu, Sep 24, 2026 at 08:53:49PM +0000, Johannes Schindelin via GitGitGadget wrote:
> 
> > +# The cURL version which Debian 12 ships (v7.88.1) can fail to retry
> > +# authentication after an early HTTP/2 response. This bug was introduced
> > +# in cURL v7.88.0 (8c762f5998 (http2: minor buffer and error path fixes,
> > +# 2023-02-08)) and fixed in v8.3.0 (https://github.com/curl/curl/pull/11756).
> > +test_lazy_prereq HAVE_CURL_HTTP2_BUG "
> > +	test_have_prereq HTTP2 &&
> > +	build_option libcurl |
> > +	awk -F. '
> > +		($1 == 7 && $2 >= 88) || ($1 == 8 && $2 < 3) { broken = 1 }
> > +		END { exit !broken }
> > +	'
> > +"
> 
> Doh, this is totally broken. The prereq snippet is in double-quotes, so
> the $1, etc in the awk invocation are interpolated before we even eval
> it.

True, I'm sorry.

> [...]
> 
> Since I know we both used GPT to work on this, I was curious if this
> slipped past it. Doesn't look like it from what I sent (which used
> option 2 above). I wonder if your agent flipped it, or if you saw how
> ugly it was and flipped it yourself. Not blaming, but it's just a funny
> and interesting data point if a human second-guessing the AI output
> introduced a bug.

I introduced that bug; I meant to double-check the quoting, saw the
single-quote characters, and that's where I stopped.

FWIW my preference would have been to move the entire code into its own
shell function, like so:

-- snip --
curl_has_http2_bug () {
	test_have_prereq HTTP2 &&
	build_option libcurl |
	awk -F. '
		($1 == 7 && $2 >= 88) || ($1 == 8 && $2 < 3) { broken = 1 }
		END { exit !broken }
	'
}
test_lazy_prereq HAVE_CURL_HTTP2_BUG curl_has_http2_bug
-- snap --

Ciao,
Johannes

> 
>  t/t5551-http-fetch-smart.sh | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/t/t5551-http-fetch-smart.sh b/t/t5551-http-fetch-smart.sh
> index f66d7ce7ac..cb681e644f 100755
> --- a/t/t5551-http-fetch-smart.sh
> +++ b/t/t5551-http-fetch-smart.sh
> @@ -21,14 +21,14 @@ start_httpd
>  # authentication after an early HTTP/2 response. This bug was introduced
>  # in cURL v7.88.0 (8c762f5998 (http2: minor buffer and error path fixes,
>  # 2023-02-08)) and fixed in v8.3.0 (https://github.com/curl/curl/pull/11756).
> -test_lazy_prereq HAVE_CURL_HTTP2_BUG "
> +test_lazy_prereq HAVE_CURL_HTTP2_BUG '
>  	test_have_prereq HTTP2 &&
>  	build_option libcurl |
> -	awk -F. '
> +	awk -F. '\''
>  		($1 == 7 && $2 >= 88) || ($1 == 8 && $2 < 3) { broken = 1 }
>  		END { exit !broken }
> -	'
> -"
> +	'\''
> +'
>  
>  test_expect_success HTTP2 'enable client-side http/2' '
>  	git config --global http.version HTTP/2
> -- 
> 2.56.0.399.g9e0ddc9b37
> 
> 
>