From: Peter Wu <peter@lekensteyn.nl>
Date: Wed, 17 Dec 2014 14:42:08 GMT
Subject: Re: [PATCH v4] remote: add --fetch and --both options to set-url
Message-ID: <4526638.yURndRDM9N@al>
In-Reply-To: <20141217143212.GA23085@peff.net>

On Wednesday 17 December 2014 09:32:13 Jeff King wrote:
> On Wed, Dec 17, 2014 at 03:18:56PM +0100, Peter Wu wrote:
> 
> > This is the fourth revision of the patch that allows for just setting the fetch
> > URL. Eric wondered why '--fetch --push' is not used to describe the state
> > '--both', so I added this to the commit message.
> 
> Thanks, I think that explanation is very clear.
> 
> This version overall looks good to me.
> 
> > The t5505-remote.sh test still passes after this change (I was unable to run the
> > full test suite as it broke due to an unrelated gpg issue).
> 
> It is it because you have gpg 2.1, and the patches to handle that are
> not yet merged to master? Or is it because you are using the new patches
> and they are breaking things for your older gpg version?
> 
> If the former, that's fine. If the latter, it would be nice to see a
> report of the breakage. :)

Rest assured, this is a gpg 2.1 issue :-)
-- 
Kind regards,
Peter
https://lekensteyn.nl