From: Franck Bui-Huu Date: Tue, 12 Sep 2006 09:00:13 GMT Subject: [PATCH] connect.c: finish_connect(): allow null pid parameter Message-ID: <4506771D.9040605@innova-card.com> In-Reply-To: <450673B7.8050704@innova-card.com> git_connect() can return 0 if we use git protocol for example. Users of this function don't know and don't care if a process had been created or not, and to avoid them to check it before calling finish_connect() this patch allows finish_connect() to take a null pid. And in that case return 0. Signed-off-by: Franck Bui-Huu --- Found it when debugging 'git archive --remote=git://...' command. I noticed that this command always exited with 1 as status. connect.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/connect.c b/connect.c index 1c6429b..e6efff9 100644 --- a/connect.c +++ b/connect.c @@ -737,6 +737,9 @@ int git_connect(int fd[2], char *url, co int finish_connect(pid_t pid) { + if (pid == 0) + return 0; + while (waitpid(pid, NULL, 0) < 0) { if (errno != EINTR) return -1; -- 1.4.2