From: Rene Scharfe <rene.scharfe@lsrfire.ath.cx>
Date: Sun, 18 Jun 2006 08:26:26 GMT
Subject: Re: [PATCH] Fix git to be (more) ANSI C99 compliant.
Message-ID: <44950E32.10904@lsrfire.ath.cx>
In-Reply-To: <1150609831500-git-send-email-octo@verplant.org>

Florian Forster schrieb:
> Using this patch I was able to build git with
> $ make CFLAGS="-Wall -Werror -ansi -pedantic -std=c99 -D_XOPEN_SOURCE=500 -D_BSD_SOURCE"
> 
> While most of this patch fixes void-pointer arithmetic and is therefore
> trivial, I had to change the use of a struct with FAMs in `diff-lib.c'. Since
> this is the first time I encountered FAMs it'd probably be a good idea if
> someone who knows would take a look at that.

Nice work!  However, could you split it up a bit?  I.e. please send one
patch per error class/topic.  A comment on why the changes are needed
would be nice too, e.g. "void pointer arithmetic is a GNU extension, get
rid of it".

Thanks,
René