From: Yannik Tausch <dev@ytausch.de>
Date: Thu, 03 Sep 2026 18:37:57 GMT
Subject: Re: pathspec: match and original in pathspec_item are const
Message-ID: <4439BA70-2C03-499D-B3CE-E43700C0A8DA@ytausch.de>
In-Reply-To: <xmqqy0dib3ue.fsf_-_@gitster.g>

> I just found [1], which is related to this patch series. I didn’t review the discussion in detail yet, will follow up.

I read this as you came to the same conclusion as me independently discovering the same issue in July. Perfect! I hope it’s fine that I took over the fix that way.

> Junio C Hamano <gitster@pobox.com> writes:
> 
>> This unfortunately triggers
>> 
>> t/unit-tests/u-dir.c: In function 'test_dir__common_prefix_skips_excluded_pathspec_items':
>> t/unit-tests/u-dir.c:53:34: error: initialization discards 'const' qualifier from pointer target type [-Werror=discarded-qualifiers]
>>   53 |                         .match = "unrelated/path",
>>      |                                  ^~~~~~~~~~~~~~~~
>> 
>> Other than that, looking good.
> 
> We may want a preparatory patch before this step.

Thanks, I will include your preparatory patch in v3.