From: Andreas Ericsson Date: Thu, 23 Feb 2006 09:48:27 GMT Subject: Re: [PATCH] fmt-merge-msg: avoid open "-|" list form for Perl 5.6 Message-ID: <43FD84EB.3040704@op5.se> In-Reply-To: <81b0412b0602230141g46dbfaev6baa5083dee2d42@mail.gmail.com> Alex Riesen wrote: > On 2/23/06, Alex Riesen wrote: > >>On 2/23/06, Junio C Hamano wrote: >> >>>"Alex Riesen" writes: >>> >>> >>>>I'll keep that in mind. But there are places where a safe pipe is unavoidable >>>>(filenames. No amount of careful quoting will save you). >>> >>>Huh? >> >>Because you never know what did the next interpreter took for unquoting: >>$SHELL, /bin/sh cmd /c, or something else. >> > > And that stupid activestate thing actually doesn't use any. Just tried: > > perl -e '$,=" ";open(F, "sleep 1000 ; # @ARGV |") and print ' > > It passed the whole string "1000 ; # @ARGV" to sleep from $PATH. > It failed to sleep at all, of course. The same code works perfectly on > almost any UNIX system. Not to be unhelpful or anything, but activestate perl seems to be quite a lot of bother. Is it worth supporting it? -- Andreas Ericsson andreas.ericsson@op5.se OP5 AB www.op5.se Tel: +46 8-230225 Fax: +46 8-230231