From: H. Peter Anvin <hpa@zytor.com>
Date: Sun, 04 Dec 2005 23:34:25 GMT
Subject: Re: [PATCH] Add compat/setenv.c, use in git.c.
Message-ID: <43937D01.8090706@zytor.com>
In-Reply-To: <7vr78sebp8.fsf@assigned-by-dhcp.cox.net>

Junio C Hamano wrote:
> 
> Oops.  Isn't the patch itself wrong, so is using alloca()?
> 
> putenv(3) says
> 
> 	int putenv(char *string);
> 
> 	The string pointed to by string becomes part of the environment,
> 	so altering the string changes the environment.
> 
> which tell sme that whatever we pass to putenv() we should *not*
> free.

Indeed.

	-hpa