From: Andreas Ericsson Date: Fri, 18 Nov 2005 10:08:40 GMT Subject: Re: [PATCH 1/5] Library code for user-relative paths, take three. Message-ID: <437DA828.6020207@op5.se> In-Reply-To: <7v8xvmsu9o.fsf@assigned-by-dhcp.cox.net> Junio C Hamano wrote: > >>+ /* This is perfectly safe, and people tend to think of the directory >>+ * where they ran git-init-db as their repository, so humour them. */ >>+ (void)chdir(".git"); > > > It might be safe, but I think it changes the behaviour of > upload-pack with strict case. My gut reaction is we would want > "if (!strict)" in front. Thoughts? > As it says in the comment; People tend to think of the directory where they ran "git init-db" as their repository, so humour them. It's nice for sharing files between devs in the office, and it *is* safe. Do as you please though. It's the generality of the -- Andreas Ericsson andreas.ericsson@op5.se OP5 AB www.op5.se Tel: +46 8-230225 Fax: +46 8-230231