From: Lukas Sandström Date: Tue, 15 Nov 2005 21:38:56 GMT Subject: Re: fix git-pack-redundant crashing sometimes Message-ID: <437A5570.70509@etek.chalmers.se> In-Reply-To: <20051115180848.561a6da5.tihirvon@gmail.com> Timo Hirvonen wrote: > On Tue, 15 Nov 2005 16:49:30 +0100 > Alex Riesen wrote: > > >>llist_sorted_difference_inplace didn't handle the match in the first >>sha1 correctly and the lists went wild everywhere. >> >>--- >> >>I noticed it on a very big repository (more than 100k files), trying >>to prune it. >>The code could profit from double-linked lists greatly, IMHO. > > > I use list.h from Linux when I need double-linked lists. It is very > easy to use, efficient and fast. > Well, well. Live and learn I suppose. I have never heard of it before. How portable is it to #include ? (non-rethorical) Would there be a performance benefit from doubly-linked list or would it just simplify parts of the code? My first implementation used d-lists, but I dropped the ->prev when I realised it was never used.