From: Brian Gernhardt <brian@gernhardtsoftware.com>
Date: Tue, 24 Aug 2010 03:51:22 GMT
Subject: Re: [PATCH] t7610: cd inside subshell instead of around
Message-ID: <432D99EA-303B-4201-9B07-7694800B4580@gernhardtsoftware.com>
In-Reply-To: <20100824030524.GF17406@burratino>


On Aug 23, 2010, at 11:05 PM, Jonathan Nieder wrote:

> While we're looking at this test script, some more nitpicks for
> squashing in. :)
> 
> -- 8< --
> Subject: t7610 (mergetool): more nitpicks
> 
> - use tabs to indent
> - do not redirect output away unnecessarily
> - avoid a subshell for 'yes "" | git mergetool file3'
> - use test_tick for reproducible, increasing timestamps
> - use test_cmp instead of 'test $foo = bar'; the former is much
>   nicer to debug with --verbose since it produces a diff.

Fair enough.  I just took a stab at the bit that irritated me the most.  Thanks for cleaning up the rest.

~~ Brian