From: Jeff Garzik Date: Thu, 09 Jun 2005 08:01:45 GMT Subject: Re: git bug? Message-ID: <42A7F769.2050800@pobox.com> In-Reply-To: <7vzmu0otg8.fsf@assigned-by-dhcp.cox.net> Junio C Hamano wrote: > Jeff, I assume you are talking about this part: > > >>>diff --git a/arch/arm/mm/minicache.c b/arch/arm/mm/minicache.c >>>deleted file mode 100644 >>>diff --git a/drivers/scsi/libata-core.c b/drivers/scsi/libata-core.c > > > that does not have anything between "deleted file..." and the > next diff about libata-core.c. > > In short, this is not really a "bug", but I am open to > suggestions for improvements (but you need to talk Linus into > accepting the changes, because changing this would also affect > his "git-apply" program as well). It's a bug and a new behavior. 'git-diff-cache -p HEAD' should not show files that I have not modified. This screws up git-diff-cache -p HEAD | diffstat -p1 | awk '{print $1}' for example. Jeff