From: David Greaves Date: Sat, 14 May 2005 08:28:24 GMT Subject: Re: [PATCH] Ignore file filter Message-ID: <4285B6A8.4080309@dgreaves.com> In-Reply-To: <20050513231229.GI32232@pasky.ji.cz> Petr Baudis wrote: >Dear diary, on Thu, May 12, 2005 at 11:30:32PM CEST, I got a letter >where David Greaves told me that... > > >># This doesn't allow the -h which is the [ arg for symlinks... >> >> > >But so is -L. And I'd just use -l... > > OK >>#. ${COGITO_LIB}cg-Xlib >>_git=${GIT_DIR:-.git} >> >> > >...but it makes no sense anyway I think to reinclude this stuff from a >cg-Xfile you are including from other scripts anyway. > > cg-Xignore isn't included - only called. it's also just a library program. Also I don't think cg-Xlib should be doing arg handling. As an include it should provide an arg handling function that the scripts call. >> if [[ $file =~ $patt ]]; then >> >> > >I'm sorry but this is really nothing my bash-2.05.0(1)-release supports. >We're already bash-only, but further reducing that to bash3 really won't >work. I *might* get convinced to add some bash2+-only feature, but only >if you'll be really good at explaining that it makes sense. > > Ah OK I don't know how to do that. I was actually aiming for glob matching when I came upon this in the manpage. I just thought it was bash and didn't think to check what version it was introduced with. >Besides, I'd prefer just the shell globs in the ignore file, as it is >done in the rest of the world, and in all the real-world scenarios I've >seen, the globs were powerful enough. > >Also, how does this interact with git-ls-files --exclude and >.git/exclude? We would have two ignoring mechanisms... > > > because one was cogito's and one was git's. Cogitos was supposed to have a more powerful, pattern based abroach. David --