From: Kaartic Sivaraam <kaartic.sivaraam@gmail.com>
Date: Mon, 18 Dec 2017 18:44:43 GMT
Subject: Re: 'git format-patch <ref> --summary' seems to be turning off the stat
Message-ID: <41f53071-185d-58a5-499c-d93208aa70fc@gmail.com>
In-Reply-To: <xmqqlghzyj9q.fsf@gitster.mtv.corp.google.com>

On Tuesday 19 December 2017 12:07 AM, Junio C Hamano wrote:
> Kaartic Sivaraam <kaartic.sivaraam@gmail.com> writes:
> 
>> Note: I do see that "--summary" is a diff-option but does that mean we
>> should't be printing stat information in the patch when the user
>> didn't mention "--no-stat"? Yeah, "git format-patch <ref> --summary
>> --stat" does bring back the stat. --- Kaartic
> 
> The old design decision shared across "log" family of commands [*1*]
> wrt to these "how and what are shown" options is that they started
> without any default set of options and the user gave all options (if
> they want both summary and stat, they gave them from the command
> line); over time they gained a set of built-in default options that
> take effect only when the user gives no option.
> 
> So, yes, giving "--summary" will turn off the built-in ones that are
> "--summary --stat" (IIRC).
>

Is it worth documenting that built-in defaults are turned off when user 
gives other options? Not sure where, though?


-- 
Kaartic