From: Derrick Stolee <stolee@gmail.com>
Date: Mon, 15 Oct 2018 13:23:14 GMT
Subject: Re: Git Test Coverage Report (Friday, Oct 12)
Message-ID: <41a53f74-9b40-c71a-d521-94dcc6e2abe9@gmail.com>
In-Reply-To: <nycvar.QRO.7.76.6.1810151007430.561@tvgsbejvaqbjf.bet>

On 10/15/2018 4:09 AM, Johannes Schindelin wrote:
> Hi Stolee,
>
> On Fri, 12 Oct 2018, Derrick Stolee wrote:
>
>> In an effort to ensure new code is reasonably covered by the test suite, we
>> now have contrib/coverage-diff.sh to combine the gcov output from 'make
>> coverage-test ; make coverage-report' with the output from 'git diff A B' to
>> discover _new_ lines of code that are not covered.
> Thanks for doing this. I do notice, though, that there are a few mentions
> of BUG() lines, e.g.
>
>> 0af129b2ed builtin/rebase--interactive2.c 267) BUG("invalid command '%d'",
>> command);
> I do not think that we will ever want to ensure that all of these lines
> get code coverage ;-) Maybe it would be possible to exclude those lines
> from the analysis?
I'll incorporate that into my build script, but leave it out of 
contrib/coverage-diff.sh in case people really want to see those lines 
when the inspect a single topic.

Thanks,
-Stolee