From: Kristoffer Haugsbakk <kristofferhaugsbakk@fastmail.com>
Date: Wed, 11 Mar 2026 07:18:04 GMT
Subject: Re: [PATCH v2] merge-file: fix BUG when --object-id is used in a worktree
Message-ID: <4176455b-87a5-4b13-a3d0-fd35b51cad37@app.fastmail.com>
In-Reply-To: <c076edd0-9057-443b-ba37-33aacde2eede@app.fastmail.com>

On Wed, Mar 11, 2026, at 07:44, Mathias Rav wrote:
>[snip]
> Signed-off-by: Mathias Rav <m@git.strova.dk>
> ---
> Thanks Karthik, Patrick, Kristoffer and Junio for your feedback.
> I've incorporated the sum of it all in this PATCH v2:
>
> - Check !repo before object_id and add a comment
> - Use term "linked worktree" instead of just "worktree" throughout
> - Use git -C instead of a subshell in test
> - Remove gitk's quotes from the commit references in the commit message
>
> As for the quotes in the commit references, I use gitk's "Copy commit
> reference" daily and am personally used to the quotes. Since
> SubmittingPatches seems to give equal preference to --pretty=reference and
> "Copy commit reference" I didn't think that the quotes were a problem.
> (I wonder how controversial it would be to remove the quotes in gitk.)

Thanks for this explanation. I was ignorant of this Gitk fact.

>[snip]