From: Derrick Stolee Date: Wed, 16 Sep 2020 22:51:27 GMT Subject: Re: [PATCH v2 00/13] more miscellaneous Bloom filter improvements, redux Message-ID: <40abfff8-3b5f-fa63-73fd-280cd80cd25f@gmail.com> In-Reply-To: On 9/16/20 2:06 PM, Taylor Blau wrote: > Hopefully this is it for this series ;). I think that it's in good shape > now, and I couldn't find anything in my own inspection that I wanted to > change. So, if others feel good, too, I think we should focus on > incremental fixes on top of this. I am also happy with this version. The test updates are rather nice. It is worth highlighging the tracing changes, in case anyone was planning to use that style of JSON data in production. I think it is better to include this simpler data model of one variable per event instead of rolling our own JSON format. Thanks, -Stolee