From: Erik Faye-Lund Date: Tue, 09 Feb 2010 15:13:26 GMT Subject: Re: [PATCH 0/4] Some improvements for git-imap-send Message-ID: <40aa078e1002090713h7e7d2f93r4cca9649e98db735@mail.gmail.com> In-Reply-To: <20100209150650.GA15982@sigill.intra.peff.net> On Tue, Feb 9, 2010 at 4:06 PM, Jeff King wrote: > On Tue, Feb 09, 2010 at 09:09:01PM +0900, Hitoshi Mitake wrote: > >>  base64.c                        |  122 ++++++++ >>  base64.h                        |   36 +++ >>  md5.c                           |  600 +++++++++++++++++++++++++++++++++++++++ >>  md5.h                           |   61 ++++ >>  md5_hmac.c                      |  137 +++++++++ >>  md5_hmac.h                      |   36 +++ > > That's a lot of extra code. Doesn't imap-send already conditionally > compile against openssl for starttls support? Can't we just get all > three of these algorithms from openssl? > I don't think OpenSSL includes SASL-support that is needed for STARTTLS. But it might make sense to use something like GSASL[1] instead of rolling all the SASL-mechanisms ourselves. [1]: http://www.gnu.org/software/gsasl/ -- Erik "kusma" Faye-Lund