From: Erik Faye-Lund Date: Fri, 05 Feb 2010 16:14:12 GMT Subject: Re: [PATCH] push: Use sideband channel for hook messages Message-ID: <40aa078e1002050814m1edb90f8lf3d8d138fa65c332@mail.gmail.com> In-Reply-To: <4B6C3E9C.7040009@viscovery.net> On Fri, Feb 5, 2010 at 4:51 PM, Johannes Sixt wrote: > Shawn O. Pearce schrieb: >> Johannes Sixt wrote: >>> What would you think about passing both channels to the async callback, >>> and the communicating parties must agree on which channel they communicate >>> by closing the unused one? It would require slight changes to all current >>> async users, though. (It also requires in the threaded case that we pass >>> dup()s of the pipe channels.) >> >> Yup, I could do that.  I feel like it might be over-engineering the >> solution a bit.  But I'll respin the patch by splitting it apart, >> and doing a bidirectional async here, since you asked nicely. > > I do agree about the over-engineering aspect. I mentioned it because in > one patch in the past Erik Faye-Lund also extended the async > infrastructure for bidirectional communication to use it in git-daemon > (Windows port). Just for reference, here's the latest version I wrote of that patch, in case it's useful to have a peak at or something: http://repo.or.cz/w/git/kusma.git/commit/682d90a174fc128910c1c8a4f81edb3cf9f0d9e2 -- Erik "kusma" Faye-Lund