From: Erik Faye-Lund <kusmabite@googlemail.com>
Date: Sat, 16 Jan 2010 09:26:29 GMT
Subject: Re: [PATCH v2 13/14] daemon: use select() instead of poll()
Message-ID: <40aa078e1001160126q34bc066as3adb9b61eac690d@mail.gmail.com>
In-Reply-To: <201001160906.26270.j6t@kdbg.org>

On Sat, Jan 16, 2010 at 9:06 AM, Johannes Sixt <j6t@kdbg.org> wrote:
> On Samstag, 16. Januar 2010, Erik Faye-Lund wrote:
>> +static inline void mingw_fd_set(int fd, fd_set *set)
>> +{
>> +     FD_SET(_get_osfhandle(fd), set);
>> +}
>>  #undef FD_SET
>> +#define FD_SET(a,b) mingw_fd_set(a,b)
>> +
>>  #undef FD_ISSET
>>  #define FD_ISSET(fd, set) __WSAFDIsSet(_get_osfhandle(fd), (fd_set
>> *)(set))
>
> Ah, yes, how obvious ;) You are going to do the same with FD_ISSET as well,
> aren't you?
>
> -- Hannes
>

Do I really need to? There's already a single function for that, with
no "ugly hidden internals" there; __WSAFDIsSet() is documented in
MSDN. I mean, Sure... I could... I just don't see the point.

-- 
Erik "kusma" Faye-Lund