From: Erik Faye-Lund Date: Wed, 30 Dec 2009 00:55:57 GMT Subject: Re: [PATCH 1/2] MinGW: Use pid_t more consequently, introduce uid_t for greater compatibility Message-ID: <40aa078e0912291655m57ea0081vddf3b64bf27e1d02@mail.gmail.com> In-Reply-To: On Wed, Dec 30, 2009 at 1:49 AM, Sebastian Schuberth wrote: > On Tue, Dec 29, 2009 at 22:09, Johannes Sixt wrote: > >>> MinGW: Use pid_t more consequently, introduce uid_t for greater >>> compatibility >> >> Why this? Compatibility with what? What's the problem with the status quo? > > I wanted to include Hany's Dos2Unix tool (hd2u) into msysGit. h2du > depends on libpopt, and either of the two requires the uid_t type, I > do not recall which. And while adding the missing uid_t, I felt it > would be right to actually use uid_t / pid_t in the function > prototypes. > Perhaps I'm missing something here... why do you need to modify the git-sources in order to include an external tool? -- Erik "kusma" Faye-Lund