From: Erik Faye-Lund <kusmabite@googlemail.com>
Date: Tue, 08 Dec 2009 13:36:49 GMT
Subject: Re: [PATCH/RFC 09/11] daemon: use run-command api for async serving
Message-ID: <40aa078e0912080536o21101f18p15c6c708b1cb6c14@mail.gmail.com>
In-Reply-To: <200912022012.08905.j6t@kdbg.org>

On Wed, Dec 2, 2009 at 8:12 PM, Johannes Sixt <j6t@kdbg.org> wrote:
> On Mittwoch, 2. Dezember 2009, Erik Faye-Lund wrote:
>> I'm not entirely sure how to make the interface, though. Any good
>> suggestions?
>
> I suggest to model finish_async_nowait() after waitpid() so that
>
>        while ((pid = waitpid(-1, &status, WNOHANG)) > 0) ...
> becomes
>        while ((pid = finish_async_nowait(&some_async, &status)) > 0) ...
>
> but where the resulting status is already "decoded", i.e. zero is success and
> non-zero is failure (including death through signal); WIFEXITED and
> WEXITSTATUS should not be applicable to status anymore.
>
> -- Hannes
>

Thanks. Implemented as suggested for the next round.

-- 
Erik "kusma" Faye-Lund