From: Erik Faye-Lund <kusmabite@googlemail.com>
Date: Thu, 26 Nov 2009 00:43:04 GMT
Subject: Re: [PATCH/RFC 00/11] daemon-win32
Message-ID: <40aa078e0911251643m7837cd82g8ea9d631c012d62@mail.gmail.com>
In-Reply-To: <1259195958-2372-1-git-send-email-kusmabite@gmail.com>

Awww, sorry people. I managed to send this one to the wrong
msysgit-account. I'll repost, as I think it's important to get that
list involved as well.

On Thu, Nov 26, 2009 at 1:39 AM, Erik Faye-Lund
<kusmabite@googlemail.com> wrote:
> This is my stab at cleaning up Mike Pape's patches for git-daemon
> on Windows for submission, plus some of my own.
>
> * Patch 1-4 originate from Mike Pape, but have been cleaned up quite
>  a lot by me. I hope Mike won't hate me. Credit have been retained,
>  as all important code here were written by Mike. The commit
>  messages were written mostly by me.
>
> * Patch 5 is a trivial old-style function declaration fix.
>
> * Patch 6 introduces two new functions to the run-command API,
>  kill_async() and is_async_alive().
>
> * Patch 7-8 removes the stdin/stdout redirection for the service
>  functions, as redirecting won't work for the threaded version.
>
> * Patch 9 converts the daemon-code to use the run-command API. This
>  is the patch I expect to be the most controversial.
>
> * Patch 10 is about using line-buffered mode instead of full-buffered
>  mode for stderr.
>
> * Patch 11 finally enables compilation of git-daemon on MinGW.
>
> Let the flames begin!
>
> Erik Faye-Lund (7):
>  inet_ntop: fix a couple of old-style decls
>  run-command: add kill_async() and is_async_alive()
>  run-command: support input-fd
>  daemon: use explicit file descriptor
>  daemon: use run-command api for async serving
>  daemon: use full buffered mode for stderr
>  mingw: compile git-daemon
>
> Mike Pape (4):
>  mingw: add network-wrappers for daemon
>  strbuf: add non-variadic function strbuf_vaddf()
>  mingw: implement syslog
>  compat: add inet_pton and inet_ntop prototypes
>
>  Makefile           |    8 ++-
>  compat/inet_ntop.c |   22 ++------
>  compat/inet_pton.c |    8 ++-
>  compat/mingw.c     |  111 +++++++++++++++++++++++++++++++++++++++++--
>  compat/mingw.h     |   32 ++++++++++++
>  daemon.c           |  134 ++++++++++++++++++++++++++--------------------------
>  git-compat-util.h  |    9 ++++
>  run-command.c      |   32 ++++++++++++-
>  run-command.h      |    2 +
>  strbuf.c           |   15 ++++--
>  strbuf.h           |    1 +
>  11 files changed, 274 insertions(+), 100 deletions(-)
>
>



-- 
Erik "kusma" Faye-Lund