From: Erik Faye-Lund Date: Fri, 21 Aug 2009 13:41:24 GMT Subject: Re: [PATCH 01/14] Fix non-constant array creation Message-ID: <40aa078e0908210641m660b003do6f637535293672ae@mail.gmail.com> In-Reply-To: <6283b3e1775f43c6fc07e5047f9c99acdc27bc8f.1250860247.git.mstormo@gmail.com> On Fri, Aug 21, 2009 at 3:30 PM, Marius Storm-Olsen wrote: > @@ -1875,7 +1875,7 @@ static int match_fragment(struct image *img, >                size_t imgoff = 0; >                size_t preoff = 0; >                size_t postlen = postimage->len; > -               size_t imglen[preimage->nr]; > +               size_t *imglen = xmalloc(sizeof(size_t) * preimage->nr); How about using alloca instead? It allocates from the stack (just like the C99-style variable-length array you're replacing), and you don't need to free the memory afterwards. ... or is alloca frowned upon? I see it's already used both in compat/regex/regex.c and in compat/nedmalloc/malloc.c, but not apparently not in the git core. -- Erik "kusma" Faye-Lund kusmabite@gmail.com (+47) 986 59 656