From: Ben Knoble <ben.knoble@gmail.com>
Date: Mon, 31 Aug 2026 15:46:29 GMT
Subject: Re: [PATCH v5 3/3] core: convert build-time USE_NSEC into runtime core.useNanosec
Message-ID: <40419516-56A6-4AA6-B0C9-4F15EA61480E@gmail.com>
In-Reply-To: <apVJCt4prIi2GgXp@pks.im>


> Le 31 août 2026 à 11:31, Patrick Steinhardt <ps@pks.im> a écrit :
> 
> On Sat, Aug 29, 2026 at 09:38:20AM -0400, D. Ben Knoble wrote:
>> diff --git a/builtin/update-index.c b/builtin/update-index.c
>> index 241abd4332..8e0c25655f 100644
>> --- a/builtin/update-index.c
>> +++ b/builtin/update-index.c
>> @@ -130,7 +130,7 @@ static void xrmdir(const char *path)
>> static void avoid_racy(void)
>> {
>>    /*
>> -     * not use if we could usleep(10) if USE_NSEC is defined. The
>> +     * not use if we could usleep(10) if core.useNanosec is defined. The
> 
> Micronit: s/defined/enabled/
> 
> Otherwise I'm happy with this patch. It looks a lot better now that we
> use less preprocessor directives. Thanks!
> 
> Patrick

Thanks, queued locally. Will send out as v6 this evening (~5–6h from now) unless I hear differently from anyone. (That comment is hard to read to begin with!)