From: Jeff Hostetler Date: Tue, 20 Feb 2024 19:10:38 GMT Subject: Re: [PATCH 06/12] fsmonitor: clarify handling of directory events in callback Message-ID: <3ffd638e-d2e1-ab39-e44f-84d2c58d8126@jeffhostetler.com> In-Reply-To: On 2/15/24 4:32 AM, Patrick Steinhardt wrote: > On Tue, Feb 13, 2024 at 08:52:15PM +0000, Jeff Hostetler via GitGitGadget wrote: >> From: Jeff Hostetler >> >> Signed-off-by: Jeff Hostetler >> --- >> fsmonitor.c | 47 +++++++++++++++++++++++++++++++++-------------- >> 1 file changed, 33 insertions(+), 14 deletions(-) >> >> diff --git a/fsmonitor.c b/fsmonitor.c >> index 614270fa5e8..754fe20cfd0 100644 >> --- a/fsmonitor.c >> +++ b/fsmonitor.c >> @@ -219,24 +219,40 @@ static void fsmonitor_refresh_callback_unqualified( ... >> +static int fsmonitor_refresh_callback_slash( >> struct index_state *istate, const char *name, int len, int pos) >> { >> int i; >> + int nr_in_cone = 0; > > Should we return `size_t` instead of `int`? > > Patrick yeah, I can fix all of the return values to be 'size_t' since that is new functionality and not colliding with the existing usages for 'i' and 'pos' that I mentioned in a response on a previous thread. Thanks Jeff