From: Ramsay Jones <ramsay@ramsayjones.plus.com>
Date: Tue, 27 May 2025 16:43:23 GMT
Subject: Re: [PATCH 04/11] builtin/maintenance: mark "--task=" and "--schedule=" as incompatible
Message-ID: <3f6863f8-7fb9-4516-a36b-f55243794dd0@ramsayjones.plus.com>
In-Reply-To: <20250527-b4-pks-maintenance-ref-lock-race-v1-4-e1ceb2dea66e@pks.im>



On 27/05/2025 15:04, Patrick Steinhardt wrote:
> The "--task=" option explicitly allows the user to say which maintenance
> tasks should be run, whereas "--schedule=" only respects the maintenance
> strategy configured for a specific repository. As such, it is sensible

s/is sensible/is not sensible/ ?

> to accept both options at the same time.
> 
> Mark them as incompatible with one another. While at it, also convert
> the existing logic that marks "--auto" and "--schedule=" as incompatible
> to use `die_for_incompatible_opt2()`.
> 
> Signed-off-by: Patrick Steinhardt <ps@pks.im>
[snip]

ATB,
Ramsay Jones