From: René Scharfe <l.s.r@web.de>
Date: Thu, 26 Oct 2017 17:12:15 GMT
Subject: Re: [PATCH 1/2] xdiff-interface: export comparing and hashing strings
Message-ID: <3f656948-273f-e01d-ad52-e460059571da@web.de>
In-Reply-To: <20171025184912.21657-2-sbeller@google.com>

Am 25.10.2017 um 20:49 schrieb Stefan Beller:
> +/*
> + * Compare the strings l1 with l2 which are of size s1 and s2 respectively.
> + * Returns 1 if the strings are deemed equal, 0 otherwise.
> + * The `flags` given as XDF_WHITESPACE_FLAGS determine how white spaces
> + * are treated for the comparision.
> + */
> +extern int xdiff_compare_lines(const char *l1, long s1,
> +			       const char *l2, long s2, long flags);

With the added comment it's OK here.

Still, I find the tendency in libxdiff to use the shortest possible
variable names to be hard on the eyes.  That math-like notation may have
its place in that external library, but I think we should be careful
lest it spreads.

René