From: Reece Dunn <msclrhd@googlemail.com>
Date: Mon, 17 Aug 2009 16:34:45 GMT
Subject: Re: [PATCH 02/11] Fix declare variable at mid of function
Message-ID: <3f4fd2640908170934w4c48ada1o66745f845ecb7d49@mail.gmail.com>
In-Reply-To: <alpine.DEB.1.00.0908171827040.4991@intel-tinevez-2-302>

2009/8/17 Johannes Schindelin <Johannes.Schindelin@gmx.de>:
> Hi,
>
> On Tue, 18 Aug 2009, Frank Li wrote:
>
>> Some compiler such as MSVC can't support declear variable at mid of funtion at c file.
>
> Please wrap your commit messages after 76 characters.
>
>>
>> Signed-off-by: Frank Li <lznuaa@gmail.com>
>> ---
>
> How about this instead?
>
>        Avoid declaration after instruction
>
>        Microsoft Visual C++ does not understand this C99 style.
>
> ?
>
> The patch itself is good.

Shouldn't GCC be changed to use -std=c89 as well to pick up errors for
compilers that don't support c99 (like the Microsoft Visual C++ C
compiler)?

- Reece