From: Reece Dunn Date: Wed, 19 Sep 2007 18:23:41 GMT Subject: Re: State of Perforce importing. Message-ID: <3f4fd2640709191123j64b53878vc96d785c13c3bca2@mail.gmail.com> In-Reply-To: <20070919171243.GA23902@old.davidb.org> On 19/09/2007, David Brown wrote: > On Wed, Sep 19, 2007 at 08:19:11AM +0200, Simon Hausmann wrote: > > >> An additional problem: > >> > >> - git-p4 doesn't preserve the execute permission bit from Perforce. > > > >Hmm, can you paste the output of > > > > p4 fstat //path/in/depot/to/file/that/is/imported/incorrectly > > > >? I'm interested in the type of the file that p4 reports. > > headType kxtext > > so the problem is that the git-p4 is only looking for an 'x' at the start. > According to 'p4 help filetypes', we need to use execute for any of: > > cxtext, kxtext, uxbinary, and the others that start with 'x'. > > I think it would be sufficient to check the first or second character for > an 'x'. I'll make a change and give it a try later today. These are the old file types. If you read the output of `p4 help filetypes`, the new way of specifying this is with file type modifiers. Therefore, you also have things like text+x. - Reece