From: Philip Oakley <philipoakley@iee.email>
Date: Mon, 02 Sep 2019 21:24:34 GMT
Subject: Re: [PATCH 1/1] rebase -r: let `label` generate safer labels
Message-ID: <3edd55ed-b507-a14a-5cfb-0bfe471efbbc@iee.email>
In-Reply-To: <xmqq5zmav9ej.fsf@gitster-ct.c.googlers.com>

On 02/09/2019 19:29, Junio C Hamano wrote:
> I see there are "lets make sure it is unique by suffixing "-%d" in
> other codepaths; would that help if this piece of code yields a
> label that is not unique?
maybe use a trailing 4 characters  of the oid to get a reasonably unique 
label?

Oh, just seen dscho's "we make sure that the labels are unique, via the 
`label_oid()` function!", maybe needs mentioning in the commit message 
if re-rolled.

Philip