From: Derrick Stolee Date: Thu, 23 Jun 2022 15:08:50 GMT Subject: Re: [PATCH v4 2/7] mv: update sparsity after moving from out-of-cone to in-cone Message-ID: <3e84bdc5-31e7-a7aa-8404-228424810f35@github.com> In-Reply-To: <20220623114120.12768-3-shaoxuan.yuan02@gmail.com> On 6/23/2022 7:41 AM, Shaoxuan Yuan wrote: > Originally, "git mv" a sparse file from out-of-cone to > in-cone does not update the moved file's sparsity (remove its > SKIP_WORKTREE bit). And the corresponding cache entry is, unexpectedly, > not checked out in the working tree. > > Update the behavior so that: > 1. Moving from out-of-cone to in-cone removes the SKIP_WORKTREE bit from > corresponding cache entry. > 2. The moved cache entry is checked out in the working tree to reflect > the updated sparsity. Since this is a behavior change, can we test it? It would be good to verify that the new path exists in the worktree after 'git mv' succeeds. Thanks, -Stolee