From: Ramsay Jones <ramsay@ramsayjones.plus.com>
Date: Tue, 04 Apr 2017 15:20:02 GMT
Subject: Re: [PATCH v5] http.postbuffer: allow full range of ssize_t values
Message-ID: <3d351f90-af4f-1ddb-c8a0-3e7926fd722d@ramsayjones.plus.com>
In-Reply-To: <20170403235308.30102-1-dturner@twosigma.com>



On 04/04/17 00:53, David Turner wrote:
> Unfortunately, in order to push some large repos, the http postbuffer
> must sometimes exceed two gigabytes.  On a 64-bit system, this is OK:
> we just malloc a larger buffer.
> 
> This means that we need to use CURLOPT_POSTFIELDSIZE_LARGE to set the
> buffer size.
> 
> Signed-off-by: David Turner <dturner@twosigma.com>
> ---
> 
> V5 addresses comments from Torsten Boegershausen and Ramsay Jones.  Since
> I don't have a 32-bit machine handy, it's difficult for me to check
> for compiler warnings on 32-bit machines.  Hopefully my guess as
> to the solution to Ramsay's issue will be correct.

Yep, this compiles without complaint.

Thanks!

ATB,
Ramsay Jones