From: Laszlo Ersek <lersek@redhat.com>
Date: Thu, 07 May 2020 12:16:36 GMT
Subject: Re: "--quiet" for git-push does not suppress remote hook output
Message-ID: <3cb011a9-ce3d-df38-01c6-062062f1c9c2@redhat.com>
In-Reply-To: <ba70b25b-906c-0117-2594-c606595c6816@redhat.com>

(Sorry about the self-followup...)

On 05/07/20 14:05, Laszlo Ersek wrote:
> Hi,
> 
> being a total novice in git internals, it seems like
> "builtin/receive-pack.c" (on the server) forwards any receive hook
> output with copy_to_sideband() back to git-push (on the client), even if
> git-push was invoked with "--quiet".
> 
> And "case 2" in demultiplex_sideband() seems to print that "band" to
> stderr (on the client), despite "--quiet".
> 
> Is this intentional? I'd prefer "git push --quiet" to suppress remote
> hook output (unless the remote hook fails).

Or else:

would it be the job of the particular receive hooks to observe and obey
the "--quiet" option in the GIT_PUSH_OPTION_* environment variables?

Thanks!
Laszlo