From: Matt McCutchen <hashproduct@gmail.com>
Date: Sun, 22 Jul 2007 23:10:43 GMT
Subject: Re: [PATCH] gitweb: Fix support for legacy gitweb config for snapshots
Message-ID: <3bbc18d20707221610q757536eet213a6d08b810b280@mail.gmail.com>
In-Reply-To: <200707222341.21538.jnareb@gmail.com>

On 7/22/07, Jakub Narebski <jnareb@gmail.com> wrote:
> This commit moves legacy configuration support out of feature_snapshot
> subroutine to separate filter_snapshot_fmts subroutine. The
> filter_snapshot_fmts is used on result on result of

There's a typo: "on result" appears twice.

> On Sun, 22 July 2007, Matt McCutchen wrote:
>
> > That said: the backward compatibility code for gitweb _site_
> > configuration is broken because it is inside an if statement that only
> > runs for gitweb _repository_ configuration.
>
> Sorry for sending not fully tested code. This should fix that.
> This commit _is_ rudimentally tested.

I tested it too and it worked.  I like the approach of using
filter_snapshot_fmts.

Matt