From: Derrick Stolee Date: Tue, 28 Aug 2018 21:31:40 GMT Subject: Re: [PATCH 1/1] commit-graph: define GIT_TEST_COMMIT_GRAPH Message-ID: <3bb1d527-87ae-5fdb-be9a-b83f6a68d3a0@gmail.com> In-Reply-To: On 8/28/2018 4:41 PM, Stefan Beller wrote: > On Tue, Aug 28, 2018 at 1:33 PM Derrick Stolee via GitGitGadget > wrote: >> From: Derrick Stolee >> >> The commit-graph feature is tested in isolation by >> t5318-commit-graph.sh and t6600-test-reach.sh, but there are many >> more interesting scenarios involving commit walks. Many of these >> scenarios are covered by the existing test suite, but we need to >> maintain coverage when the optional commit-graph structure is not >> present. >> >> To allow running the full test suite with the commit-graph present, >> add a new test environment variable, GIT_TEST_COMMIT_GRAPH. Similar >> to GIT_TEST_SPLIT_INDEX, this variable makes every Git command try >> to load the commit-graph when parsing commits, and writes the >> commit-graph file after every 'git commit' command. >> >> There are a few tests that rely on commits not existing in >> pack-files to trigger important events, so manually set >> GIT_TEST_COMMIT_GRAPH to false for the necessary commands. > So the plan is to turn on the commit graph for the whole test suite > excluding these selected tests? Excluding these specific _steps_, but yes. > >> + GIT_TEST_COMMIT_GRAPH=0 && >> + test_must_fail git merge -m final G > This could go on the same line without the && in between, setting the > variable as a prefix. It cannot! The Linux build I ran complained that you can't put environment variables through test_must_fail. -Stolee