From: René Scharfe Date: Sun, 30 Oct 2022 11:49:37 GMT Subject: [PATCH v2 06/12] sequencer: simplify building argument list in do_exec() Message-ID: <3ba55be2-c0f7-77e6-1b40-323786ccc2bb@web.de> In-Reply-To: Build child_argv during initialization, taking advantage of the C99 support for initialization expressions that are not compile time constants. This avoids the use of a magic index constant and is shorter and simpler. Signed-off-by: René Scharfe --- sequencer.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/sequencer.c b/sequencer.c index debb2ecbaf..66eedd2c76 100644 --- a/sequencer.c +++ b/sequencer.c @@ -3558,11 +3558,10 @@ static int error_failed_squash(struct repository *r, static int do_exec(struct repository *r, const char *command_line) { - const char *child_argv[] = { NULL, NULL }; + const char *child_argv[] = { command_line, NULL }; int dirty, status; fprintf(stderr, _("Executing: %s\n"), command_line); - child_argv[0] = command_line; status = run_command_v_opt(child_argv, RUN_USING_SHELL); /* force re-reading of the cache */ -- 2.38.1