From: Justin Tobler <jltobler@gmail.com>
Date: Fri, 03 Jan 2025 01:58:24 GMT
Subject: Re: [PATCH 6/9] builtin/log: use `size_t` to track indices
Message-ID: <3b7ep2hex2vae56p2ba2kjeextjrjcsu5jrufr7hqewrnv3z45@ftrrcuvihxxs>
In-Reply-To: <20241227-b4-pks-commit-reach-sign-compare-v1-6-07c59c2aa632@pks.im>

On 24/12/27 11:46AM, Patrick Steinhardt wrote:
> Similar as with the preceding commit, adapt "builtin/log.c" so that it
> tracks array indices via `size_t` instead of using signed integers. This
> fixes a couple of -Wsign-compare warnings and prepares the code for
> a similar refactoring of `repo_get_merge_bases_many()` in a subsequent
> commit.
> 
> Signed-off-by: Patrick Steinhardt <ps@pks.im>
> ---
>  builtin/log.c | 23 +++++++++++++----------
>  1 file changed, 13 insertions(+), 10 deletions(-)
> 
[snip]
>  	if (show_progress)
>  		progress = start_delayed_progress(_("Generating patches"), total);
> -	while (0 <= --nr) {
> +	for (i = 0; i < nr; i++) {
> +		size_t idx = nr - i - 1;
>  		int shown;
> -		display_progress(progress, total - nr);
> -		commit = list[nr];
> -		rev.nr = total - nr + (start_number - 1);
> +
> +		display_progress(progress, total - idx);
> +		commit = list[idx];
> +		rev.nr = total - idx + (start_number - 1);

Along with updating array indices variables to use `size_t`, the loop
structure here is also changed. Instead of iterating backwards from
`nr`, the loop iterator increases and each iteration computes the index
starting from the end. This is functionally the same behavior and it
looks like it was done to improve readability.

> +
>  		/* Make the second and subsequent mails replies to the first */
>  		if (cfg.thread) {
>  			/* Have we already had a message ID? */
> 
> -- 
> 2.48.0.rc0.184.g0fc57dec57.dirty
> 
>