From: Johannes Sixt <j6t@kdbg.org>
Date: Wed, 03 Apr 2019 18:16:09 GMT
Subject: Re: [PATCH v2.5 2/2] tag: prevent nested tags
Message-ID: <3a7a9348-188e-e2c1-58d9-52310b96081d@kdbg.org>
In-Reply-To: <xmqqzhp7sfw4.fsf@gitster-ct.c.googlers.com>

Am 03.04.19 um 09:32 schrieb Junio C Hamano:
> Denton Liu <liu.denton@gmail.com> writes:
> 
>> This is the first use of the '%n$<fmt>' style of printf format in the
>> *.[ch] files in our codebase, but it's supported by POSIX[1] and there
>> are existing uses for it in po/*.po files, so hopefully it won't cause
> 
> The latter is a stronger indication that this should be OK than the
> former ;-)  Thanks for digging and noting.

However, there is a difference in whether %n$ is in the code or just in
the translations: When it is not in the code, Git can be made to work on
a platform that does not support it by compiling with NO_GETTEXT. When
it is in the code, that won't be possible anymore.

I don't know whether there are any platforms that do not support %n$,
though.

-- Hannes