From: Torsten Bögershausen <tboegi@web.de>
Date: Sun, 22 May 2016 06:07:05 GMT
Subject: Re: [PATCH v7 1/9] connect: document why we sometimes call get_port after get_host_and_port
Message-ID: <399331a6-dadb-c318-b0e0-c83e0f81ecb0@web.de>
In-Reply-To: <20160521231732.4888-2-mh@glandium.org>

On 22.05.16 01:17, Mike Hommey wrote:
> Signed-off-by: Mike Hommey <mh@glandium.org>
> ---
>  connect.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/connect.c b/connect.c
> index c53f3f1..caa2a3c 100644
> --- a/connect.c
> +++ b/connect.c
> @@ -742,6 +742,12 @@ struct child_process *git_connect(int fd[2], const char *url,
>  			transport_check_allowed("ssh");
>  			get_host_and_port(&ssh_host, &port);
>  
> +			/* get_host_and_port may not return a port even when
> +			 * there is one: In the [host:port]:path case,
> +			 * get_host_and_port is called with "[host:port]" and
> +			 * returns "host:port" and NULL.
> +			 * In that specific case, we still need to split the
> +			 * port. */
Is it worth to mention that this case is "still supported legacy" ?