From: Nicolas Morey-Chaisemartin <nmoreychaisemartin@suse.de>
Date: Wed, 09 Aug 2017 18:03:05 GMT
Subject: Re: [PATCH 2/4] http: drop support for curl < 7.16.0
Message-ID: <38dfdc54-65ea-694a-4b72-fe0006a008cf@suse.de>
In-Reply-To: <xmqq1sok7i82.fsf@gitster.mtv.corp.google.com>



Le 09/08/2017 à 19:40, Junio C Hamano a écrit :
> Jeff King <peff@peff.net> writes:
>
>> -#if LIBCURL_VERSION_NUM >= 0x071700
>> -/* Use CURLOPT_KEYPASSWD as is */
>> -#elif LIBCURL_VERSION_NUM >= 0x070903
>> -#define CURLOPT_KEYPASSWD CURLOPT_SSLKEYPASSWD
>> -#else
>> -#define CURLOPT_KEYPASSWD CURLOPT_SSLCERTPASSWD
>> -#endif
>> -
> This part I am not sure.  Don't we still need to substitute
> CURLOPT_KEYPASSWD with CURLOPT_SSLKEYPASSWD for versions below
> 071700, e.g. 071000 which is 7.16.0?
According to the documentation:

https://curl.haxx.se/libcurl/c/CURLOPT_KEYPASSWD.html
This option was known as CURLOPT_SSLKEYPASSWD up to 7.16.4 and CURLOPT_SSLCERTPASSWD up to 7.9.2.


So the patch breaks things (broken for 7.16.[0-4]). But the series does not as the next patch ensure at least 7.19.4