From: Francis Moreau <francis.moro@gmail.com>
Date: Mon, 11 Aug 2008 17:38:05 GMT
Subject: Re: git-bisect: weird usage of read(1)
Message-ID: <38b2ab8a0808111038q686c9581pb277ab6d2229afd@mail.gmail.com>
In-Reply-To: <48A06659.6010004@lsrfire.ath.cx>

On Mon, Aug 11, 2008 at 6:18 PM, René Scharfe
<rene.scharfe@lsrfire.ath.cx> wrote:
> Francis Moreau schrieb:
>> I found this in git bisect:
>>
>>               printf >&2 'Are you sure [Y/n]? '
>>               case "$(read yesno)" in [Nn]*) exit 1 ;; esac
>>
>> which looks very weird since read(1) returns a status and not the
>> string reads from std input.
>
> Good catch.  You need to press Ctrl-C in order to exit, answering "no"
> means the same as "yes" here -- not very nice.  Care to send a patch?
>

done.

-- 
Francis