From: Derrick Stolee <stolee@gmail.com>
Date: Wed, 02 May 2018 13:45:22 GMT
Subject: Re: [PATCH v3 00/12] get_short_oid UI improvements
Message-ID: <385be5ef-7d0d-7e5d-4373-4d85c1a36a0d@gmail.com>
In-Reply-To: <f35aeda5-8f41-f457-736e-393e95f530ec@gmail.com>

On 5/2/2018 8:42 AM, Derrick Stolee wrote:
> On 5/1/2018 2:40 PM, Ævar Arnfjörð Bjarmason wrote:
>> The biggest change in v3 is the no change at all to the code, but a
>> lengthy explanation of why I didn't go for Derrick's simpler
>> implementation. Maybe I'm wrong about that, but I felt uneasy
>> offloading undocumented (or if I documented it, it would only be for
>> this one edge-case) magic on the oid_array API. Instead I'm just
>> making this patch a bit more complex.
>
> I think that's fair. Thanks for going along with me on the thought 
> experiment.

Also, v3 looks good to me.

Reviewed-by: Derrick Stolee <dstolee@microsoft.com>