From: Phillip Wood <phillip.wood123@gmail.com>
Date: Wed, 15 Jul 2026 09:12:58 GMT
Subject: Re: [PATCH v2 02/10] sequencer: move definition of is_final_fixup()
Message-ID: <3856a84b-4680-41fd-bae6-3fab538dc3d7@gmail.com>
In-Reply-To: <20260714225056.2285055-1-rybak.a.v@gmail.com>

Hi Andrei

On 14/07/2026 23:50, Andrei Rybak wrote:
>> Move this function earlier in the file in preparation for adding a
>> new caller in a later commit.
>>
>> @@ -4925,6 +4910,21 @@ static int reread_todo_if_changed(struct repository *r,
> 
> 4910 is greater than 4627, the function is_final_fixup() seems to have been
> moved _later_ in the file.  But the commit message says "Move this function
> earlier in the file".  Am I missing something?

Oh, thanks for the sanity check. I could have sworn I had to move this 
function to get a later commit to compile at one point, but it clearly 
doesn't need to move now. I'll drop this patch.

Thanks

Phillip

> 
>>   	strbuf_release(&buf);
>>   
>>   	return 0;
>> +}
>> +
>> +static int is_final_fixup(struct todo_list *todo_list)
>> +{
>> +	int i = todo_list->current;
>> +
>> +	if (!is_fixup(todo_list->items[i].command))
>> +		return 0;
>> +
>> +	while (++i < todo_list->nr)
>> +		if (is_fixup(todo_list->items[i].command))
>> +			return 0;
>> +		else if (!is_noop(todo_list->items[i].command))
>> +			break;
>> +	return 1;
>>   }
>>   
>>   static const char rescheduled_advice[] =
>> -- 
>> 2.54.0.200.gfd8d68259e3