From: Dmitry Potapov Date: Wed, 16 Jul 2008 14:33:37 GMT Subject: Re: [PATCH] Fix buffer overflow in git-grep Message-ID: <37fcd2780807160733o156e49c6m51314ff18764ccd5@mail.gmail.com> In-Reply-To: <20080716115420.GD2925@dpotapov.dyndns.org> On Wed, Jul 16, 2008 at 3:54 PM, Dmitry Potapov wrote: > > For instance, git show will show you nothing at all and exit with 0. > The same problem with git whatchanged. The whole history mysteriously > disappeared at that commit, and git whatchanged exited with 0 without > any error or warning... Though git log will show you all history, but > if you run it with -p then it will also exit with zero at this commit > silently like previously history do not exist at all. It turned out that git actually crashed while doing diff, but because it was a forked process, the parent exited normally with code 0. I wonder should not the parent process to exit with a non-zero code if the child died by SIGSEG or another signal? Dmitry