From: Derrick Stolee Date: Mon, 19 Nov 2018 19:10:39 GMT Subject: Re: Git Test Coverage Report (v2.20.0-rc0) Message-ID: <37b2c29d-43bb-9987-e91c-cb3e6b65d354@gmail.com> In-Reply-To: <871s7g29zy.fsf@evledraar.gmail.com> On 11/19/2018 1:33 PM, Ævar Arnfjörð Bjarmason wrote: > On Mon, Nov 19 2018, Derrick Stolee wrote: > >> Here is a test coverage report for the uncovered lines introduced in >> v2.20.0-rc0 compared to v2.19.1. > Thanks a lot for this. > >> [...] >> builtin/rebase.c >> 62c23938fa 55) return env; >> [...] >> Ævar Arnfjörð Bjarmason 62c23938f: tests: add a special setup >> where rebase.useBuiltin is off > This one would be covered with > GIT_TEST_REBASE_USE_BUILTIN=false. Obviously trivial, but I wonder if > the rest of the coverage would look different when passed through the various GIT_TEST_* options. The coverage report has been using the following: export GIT_TEST_MULTI_PACK_INDEX=1 export GIT_TEST_COMMIT_GRAPH=1 export GIT_TEST_INDEX_VERION=4 export GIT_TEST_SPLIT_INDEX=yes export GIT_TEST_OE_SIZE=10 export GIT_TEST_OE_DELTA_SIZE=5 I need to add GIT_TEST_INDEX_THREADS=2 and GIT_TEST_REBASE_USE_BUILTIN=false Thanks! -Stolee